Updates to scoringutils 1.0.0 #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nikosbosse
commented
Mar 25, 2022
nikosbosse
commented
- updates to the manuscript
- small fixes
Former-commit-id: 263eeeaecc84252492383baec202b9c8ba206aba
Former-commit-id: 44761929f92e4e8c80618d9ca6869c2bf84cd50a
Codecov Report
@@ Coverage Diff @@
## master #203 +/- ##
==========================================
+ Coverage 56.68% 56.80% +0.12%
==========================================
Files 22 22
Lines 1362 1366 +4
==========================================
+ Hits 772 776 +4
Misses 590 590
Continue to review full report at Codecov.
|
This was referenced Mar 25, 2022
Closed
seabbs
reviewed
Mar 25, 2022
| @@ -116,6 +131,9 @@ | |||
| #' A data set with truth values for COVID-19 cases and deaths | |||
| #' submitted to the European Forecast Hub. | |||
| #' | |||
| #' The data was created using the script create-example-data.R in the inst/ | |||
|
|
||
| NULL | ||
| #' @keywords internal | ||
| "_PACKAGE" |
There was a problem hiding this comment.
you caved on the custom package file 😱
| @@ -2,7 +2,7 @@ library(data.table) | |||
| library(dplyr) | |||
| library(devtools) | |||
| library(here) | |||
| library(covidHubUtils) # devtools::install_github("reichlab/covidHubUtils") | |||
| library(covidHubUtils) # devtools::install_github("reichlab/covidHubUtils") #nolint | |||
There was a problem hiding this comment.
linter so mad. To skip successfully use # nolint.
| system("svn checkout https://github.com/epiforecasts/covid19-forecast-hub-europe/trunk/data-processed/EuroCOVIDhub-baseline") | ||
| system("svn checkout https://github.com/epiforecasts/covid19-forecast-hub-europe/trunk/data-processed/UMass-MechBayes") | ||
| system("svn checkout https://github.com/epiforecasts/covid19-forecast-hub-europe/trunk/data-processed/epiforecasts-EpiNow2") | ||
| system("svn checkout https://github.com/epiforecasts/covid19-forecast-hub-europe/trunk/data-processed/EuroCOVIDhub-ensemble") # nolint |
There was a problem hiding this comment.
if you want can instead use the scripts I wrote for downloading nowcasting. Much less ick than having to install utils.....
There was a problem hiding this comment.
I'll leave that to future Nikos 👀
This was referenced Mar 26, 2022
|
Also really not a fan of this mega PR approach fyi. |
|
Me neither 👀
I'll try and do better in the future :)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.